Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Patch socket.io packages for node16 moduleResolution #18170

Merged

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Nov 6, 2023

This PR patches socket.io-client and engine.io-client, applying the changes from socketio/socket.io-client#1595 and socketio/engine.io-client#711, respectively.

I think this is a safe change because we are using only types from the package, and the .d.ts/exported API still refers to the real socket.io-client package, so consumers should see no difference - they might still hit the same bug we're hitting, but only when using node16 moduleResolution.

AB#6140

@github-actions github-actions bot added dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Nov 6, 2023
package.json Outdated Show resolved Hide resolved
syncpack.config.cjs Outdated Show resolved Hide resolved
@Josmithr
Copy link
Contributor

Josmithr commented Nov 6, 2023

Could we add a README in the patches directory (assuming we don't already have one) and add docs explaining what the patches are, why we need them, and link to the appropriate work items whose completion would enable us to remove these?

@tylerbutler
Copy link
Member Author

Could we add a README in the patches directory (assuming we don't already have one) and add docs explaining what the patches are, why we need them, and link to the appropriate work items whose completion would enable us to remove these?

Added a readme.

@tylerbutler tylerbutler closed this Nov 6, 2023
@tylerbutler tylerbutler reopened this Nov 6, 2023
Copy link
Contributor

@Josmithr Josmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the docs!

@tylerbutler tylerbutler merged commit 66a7043 into microsoft:main Nov 6, 2023
25 checks passed
@tylerbutler tylerbutler deleted the module-resolution-node16-groundwork branch November 6, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants