-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Patch socket.io packages for node16 moduleResolution #18170
build: Patch socket.io packages for node16 moduleResolution #18170
Conversation
Could we add a README in the |
Added a readme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the docs!
This PR patches socket.io-client and engine.io-client, applying the changes from socketio/socket.io-client#1595 and socketio/engine.io-client#711, respectively.
I think this is a safe change because we are using only types from the package, and the .d.ts/exported API still refers to the real socket.io-client package, so consumers should see no difference - they might still hit the same bug we're hitting, but only when using node16 moduleResolution.
AB#6140