refactor(merge-tree sequence matrix): enable noImplicitAny #18236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
|
I love this change! I think you may need to merge the latest main, because the tsconfigs have been changing. |
github-actions
bot
added
the
dependencies
Ahhhh, I see this is targeting next, which makes sense. The PR that changes the tsconfigs is #18152, so if it's possible to wait for that to make it to |
|
Of course, just let me know if you notice it's been merged. I'll also keep my eye out. |
This is the main-next PR that includes the change: #18248 |
tylerbutler
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables noImplicitAny in merge-tree, sequence, and matrix.
Note that it explicitly disables it for test code, though this is not necessary. The type-tests seem to break with this enabled for tests, and I haven't yet investigated why. For now it seems sane to skip the tests.