build(merge-tree,sequence): Fix type generation for ESM and add exports field #18825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
⯆ @fluid-example/bundle-size-tests: -233.95 KB
Baseline commit: eb21fdd |
This was referenced Dec 14, 2023
tylerbutler
commented
Dec 14, 2023
Comment on lines
+25
to
+34
| "./dist/test": { | ||
| "import": { | ||
| "types": "./dist/test/index.d.ts", | ||
| "default": "./dist/test/index.cjs" | ||
| }, | ||
| "require": { | ||
| "types": "./dist/test/index.d.ts", | ||
| "default": "./dist/test/index.cjs" | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| "./dist/test": { | |
| "import": { | |
| "types": "./dist/test/index.d.ts", | |
| "default": "./dist/test/index.cjs" | |
| }, | |
| "require": { | |
| "types": "./dist/test/index.d.ts", | |
| "default": "./dist/test/index.cjs" | |
| } | |
| } | |
| "./dist/test": { | |
| "types": "./dist/test/index.d.ts", | |
| "default": "./dist/test/index.cjs" | |
| } |
There was a problem hiding this comment.
Not going to risk changing it, though.
tylerbutler
changed the title
Josmithr
reviewed
Dec 14, 2023
Josmithr
reviewed
Dec 14, 2023
| "default": "./dist/index.cjs" | ||
| } | ||
| }, | ||
| "./dist/test": { |
There was a problem hiding this comment.
Would it be better to just call this ./test? Would clean up some import patterns nicely.
There was a problem hiding this comment.
Sure, but in a future change, because doing that require more churn.
Josmithr
reviewed
Dec 14, 2023
Josmithr
approved these changes
Dec 14, 2023
tylerbutler
commented
Dec 14, 2023
tyler-cai-microsoft
pushed a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Jan 10, 2024
…ts field (microsoft#18825) This PR updates sequence and merge-tree to generate proper types in ESM builds and adds an exports field. I had to update the test files a bit to clean up imports. I also added a ./dist/test export from merge-tree since its internals are used by sequence tests. This is a demonstration of the mechanism we will have to use any time we want to export something for use in another package. No more reaching into internals! This PR includes some configuration and settings changes that are not strictly needed for this PR, but splitting them out doesn't seem worth the time since they're all needed for other pending PRs like microsoft#18823 and microsoft#18824.
tyler-cai-microsoft
pushed a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Jan 10, 2024
…ts field (microsoft#18825) This PR updates sequence and merge-tree to generate proper types in ESM builds and adds an exports field. I had to update the test files a bit to clean up imports. I also added a ./dist/test export from merge-tree since its internals are used by sequence tests. This is a demonstration of the mechanism we will have to use any time we want to export something for use in another package. No more reaching into internals! This PR includes some configuration and settings changes that are not strictly needed for this PR, but splitting them out doesn't seem worth the time since they're all needed for other pending PRs like microsoft#18823 and
tyler-cai-microsoft
added a commit
that referenced
this pull request
Jan 10, 2024
Ported PRs: - #18822 - #18825 ## Description Our partner team notified us of a 150kb increase in size when consuming `2.0.0-internal.8.0.0`. After an investigation into our bundle size telemetry, it was determined that these two commits in main had reduced the bundle size by about ~100kb. ## Impact Reduce bundle size by ~100kb. --------- Co-authored-by: Tyler Butler <tylerbu@microsoft.com>
tyler-cai-microsoft
added a commit
that referenced
this pull request
Jan 10, 2024
Ported PRs: - #18822 - #18825 ## Description Our partner team notified us of a 150kb increase in size when consuming `2.0.0-internal.7.4.x`. After an investigation into our bundle size telemetry, it was determined that these two commits in main had reduced the bundle size by about ~100kb. ## Impact Reduce bundle size by ~100kb. --------- Co-authored-by: Tyler Butler <tylerbu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates sequence and merge-tree to generate proper types in ESM builds and adds an exports field. I had to update the test files a bit to clean up imports. I also added a ./dist/test export from merge-tree since its internals are used by sequence tests. This is a demonstration of the mechanism we will have to use any time we want to export something for use in another package. No more reaching into internals!
This PR includes some configuration and settings changes that are not strictly needed for this PR, but splitting them out doesn't seem worth the time since they're all needed for other pending PRs like #18823 and #18824.