Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Disable jest cache for app-insights-logger tests #20037

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Mar 8, 2024

Description

We've seen a few instances of these jest tests failing in CI pipeline runs (e.g. here and here; msft internal), where the process seemingly crashes (no jest output). Locally, this reproduces for me every single time.

Investigation led me to this which made my local runs pass consistently. The issue seems to be with --experimental-vm-modules (they're still experimental, after all). At the end of that thread this node issue is referenced, which is fixed but the fix did not make it into Node20. When we move to Node21+ we might be able to remove this workaround.

Note: since these are the only tests that use --experimental-vm-modules (because they're the only ones which exercise a code path where we do a dynamic import(), if I recall correctly) I don't expect other jest tests in the repo to require the same workaround.

Reviewer Guidance

The review process is outlined on this wiki page.

@github-actions github-actions bot added the area: examples Changes that focus on our examples label Mar 8, 2024
@alexvy86 alexvy86 requested review from seanimam, zhenmichael and a team March 8, 2024 19:29
@github-actions github-actions bot added the base: main PRs targeted against main branch label Mar 8, 2024
@alexvy86 alexvy86 enabled auto-merge (squash) March 8, 2024 19:31
@alexvy86 alexvy86 merged commit dbcfb81 into microsoft:main Mar 8, 2024
31 checks passed
@alexvy86 alexvy86 deleted the jest-no-cache branch March 8, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Changes that focus on our examples base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants