fix(version-tools): Fix scheme detection and add more test cases #21710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
zhenmichael
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #21641 I tried to fix version comparisons between semver and RC prereleasse builds. Unfortunately, the fix was flawed because the scheme detection was not run on the input version, but rather the "internal version" in the case of internal/RC builds. This caused patch releases to get identified as major releases in the RC pipelines, which in turn causes GH releases to be created incorrectly.
I corrected the code by running schema detection earlier in the function, and I added several test cases around RC versions to ensure the bug was addressed.