feat(server): switch ping-pong latency aggregation to per-socket #23856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches the R11s Socket latency telemetry from global aggregation (average over time) to per-socket aggregation (average over threshold ping-pong events). This allows for better telemetry granularity (percentiles, tenant/document narrowing, etc.) at the cost of more generated telemetry. The amount of telemetry can be tuned with the
pingPongLatencyTrackingAggregationThreshold
config, where 1 ping-pong event should happen every ~25 seconds.Breaking Changes
An internal param that was never used was removed, and a config that was never set was removed.