PR for Issue #471 Adding raii_thread only.
#504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Bikeshed issue: Do we really want to say "raii_thread"? Yes, that's what it is, but why not "joining_thread" or "scoped_thread"? Let me fire off some email to the Guideline editors to ask about the shed color... |
|
Making a clean branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
<gsl/gsl_thread>andtests/thread_tests.cppPartially fixes Issue #471 (without detached_thread)
Notes:
This PR does not include
detached_threadas per @hsutter request in PR #481I have copied the interface of std::thread.