Fix for: issue #471 Adds gsl::joining_thread #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea why some of these are failing. This branch does not touch the |
|
I suspect this is waiting for a fix for Issue: #510 |
…nto joining_thread
Added -pthread flag to Clang build
paweldac
reviewed
Nov 6, 2017
| @@ -53,6 +54,16 @@ target_compile_options(gsl_tests_config INTERFACE | |||
| > | |||
| ) | |||
|
|
|||
| target_link_libraries(gsl_tests_config INTERFACE | |||
| $<$<CXX_COMPILER_ID:GNU>: | |||
| -pthread | |||
There was a problem hiding this comment.
CMake provides functionality to discover currently used threading library.
find_package(Threads)
and
${CMAKE_THREAD_LIBS_INIT} or Threads::Threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds <gsl/gsl_thread> and tests/thread_tests.cpp
As per discussion in CppCoreGuidelines isocpp/CppCoreGuidelines#925
This PR provides
gsl::joining_thread(gsl::detached_thread was removed)