Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* Add admin owner group on upgrade * detailed logging #231

Merged
merged 2 commits into from
Feb 26, 2019
Merged

* Add admin owner group on upgrade * detailed logging #231

merged 2 commits into from
Feb 26, 2019

Conversation

shhsu
Copy link

@shhsu shhsu commented Feb 22, 2019

No description provided.

@shhsu shhsu requested review from jimmyca15 and a team February 22, 2019 19:45
jimmyca15
jimmyca15 reviewed Feb 22, 2019
View reviewed changes
scripts/setup/config.ps1 Outdated Show resolved Hide resolved
jimmyca15
jimmyca15 approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@jimmyca15 jimmyca15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes for comments and function name requested. Everything else looks good.

@shhsu shhsu merged commit 5285cf8 into dev Feb 26, 2019
@shhsu shhsu deleted the shhsu/migrate branch February 26, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyca15 jimmyca15 jimmyca15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shhsu @jimmyca15