Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dask] [ci] scikit-learn compatibility tests failing #4031

Closed
jameslamb opened this issue Mar 1, 2021 · 1 comment · Fixed by #4032
Closed

[dask] [ci] scikit-learn compatibility tests failing #4031

jameslamb opened this issue Mar 1, 2021 · 1 comment · Fixed by #4032
Labels
dask

Comments

@jameslamb
Copy link
Collaborator

Description

CI jobs have started failing in the last few days with the following error:

______________ test_parameters_default_constructible[estimator1] _______________

estimator = DaskLGBMRegressor()

    @pytest.mark.parametrize("estimator", list(_tested_estimators()))
    def test_parameters_default_constructible(estimator):
        name, Estimator = estimator.__class__.__name__, estimator.__class__
>       sklearn_checks.check_parameters_default_constructible(name, Estimator)

../tests/python_package_test/test_dask.py:1257: 

E           TypeError: type() takes 1 or 3 arguments

For example, I see these failures on #4027 and they seem unrelated to that PR's changes.

Reproducible example

I haven't figured out a reproducible example yet. I expected it is something that changed between scikit-learn versions. Will investigate right now and submit a fix shortly.
This was referenced Mar 1, 2021
Merged
Merged
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Mar 1, 2021
@jameslamb
[dask] [ci] add support for scikit-learn 0.24+ in tests (fixes micros…
1fa7e68 
…oft#4031)
@jameslamb jameslamb mentioned this issue Mar 1, 2021
Merged
StrikerRUS added a commit that referenced this issue Mar 2, 2021
@jameslamb @StrikerRUS
[dask] [ci] add support for scikit-learn 0.24+ in tests (fixes #4031) (…
2a00b6f 
…#4032)

* [dask] [ci] add support for scikit-learn 0.24+ in tests (fixes #4031)

* Update tests/python_package_test/test_dask.py

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* try upgrading mixtexsetup

* they changed the executable name UGH

* more changes for executable name

* another path change

* changing package mirrors

* undo experiments

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot removed the blocking label Aug 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dask
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dask] [ci] add support for scikit-learn 0.24+ in tests (fixes #4031) jameslamb/LightGBM
1 participant
@jameslamb