[docs][python][R] early_stopping_rounds doesn't check all of eval_set #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The document of `early_stopping_rounds` says it will check all of eval_set. But, this is not true. It doesn't check the dataset specified as the training data. This change appends an extra phrase "except the training data" to all of the sentences "If there's more than one, will check all of them" in documents.
|
|
|
Fixes #1374 edited by @StrikerRUS for auto-close the issue |
StrikerRUS
approved these changes
May 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The document of
early_stopping_roundssays it will check all ofeval_set. But, this is not true. It doesn't check the dataset
specified as the training data.
This change appends an extra phrase "except the training data" to all
of the sentences "If there's more than one, will check all of them" in
documents.