-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] copy old Booster's attributes to new one in refit method #1699
Conversation
@guolinke What is your opinion on |
I think the |
Sorry, I'm not sure that I fully understood the part about |
@StrikerRUS it this ready to merge ? |
@guolinke
I suppose, Appveyor fails due to the new release (0.20) of scikit-learn which brought new (Deprecation and Future) warnings. I will take a look at this today. |
@StrikerRUS |
Fixed #1657.
I'm confused about the need to copy
https://github.com/Microsoft/LightGBM/blob/a760eae4ff06fa8d522ed53e7df8c31d9e8298f0/python-package/lightgbm/basic.py#L1438
Also, I'm not sure whether
__attr
should be copied.But I suppose that it's logically correct to reset the info connected to the previous data (e.g.
__train_data_name
,best_iteration
,valid_sets
, etc.) after calling therefit
method.