[python] added get_split_value_histogram method #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
approved these changes
Mar 9, 2019
|
Is docstring OK? I tried to make it informative and simple at the same time, but I'm still not satisfied 😕 |
|
@StrikerRUS it looks good to me |
|
OK, thanks! Can we merge then or second review is needed? |
|
@StrikerRUS I think it is ready for merge |
|
@guolinke I've found that it crashes with categorical feature (threshold has string type). What do you think we can do with it? Simply raise error for cat. feature or is there any smarter solution? |
|
@StrikerRUS |
|
|
|
@StrikerRUS yeah, the combination is a problem. Let us skip the categorical features for now. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #2013.
Calculate feature split histogram in XGBoost-style (https://github.com/dmlc/xgboost/blob/master/python-package/xgboost/core.py#L1694-L1737).
UPD: … and in standard (numpy) style.