-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Use first_metric_only flag for early_stopping function. #2049
[python] Use first_metric_only flag for early_stopping function. #2049
Conversation
In order to apply early stopping with only first metric, applying first_metric_only flag for early_stopping function.
The following error may be CI environment problem on appveyor. TravisCI and Azure DevOps have same issue. How to deal with it to solve...? https://ci.appveyor.com/project/guolinke/lightgbm/builds/23063424/job/7unpekbvoh1gwt3r
|
This reverts commit 1e75a1a.
@StrikerRUS can you help to review this? Thank you! |
@matsuken92 Thanks for your contribution! Can you please write a test for the enhancement you are proposing? I think it'll be rather straightforward with self-defined dummy metrics. |
1c804f7
to
6ba245e
Compare
I went ahead and added simple test and updated docs with info about the new feature. |
one question: |
I think that the behavior with multiple valid sets should remain unchanged:
|
@StrikerRUS @matsuken92 I think this implementation is only for the first metric of first validation set. |
Then it should be addressed in #2127 to preserve documented behavior, I think. |
In order to apply early stopping with only first metric, applying first_metric_only flag for early_stopping function.