Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved python tree plots #2304
Improved python tree plots #2304
Changes from all commits
442db7e
0ade18f
3655199
1a8ec2c
7bef020
6d0de1a
7e1f705
0e713b7
49ca769
8cb62a9
45f4d0e
41bec87
4f7ec67
a8ba552
8968b30
6cb343d
f30cacc
0e8e51d
59f3694
77bcccc
a8f4496
79c8cb7
aa7b96b
cea089b
0bb1533
04b0cd7
340a254
87e7a88
51523c7
8ab0ae5
178f593
b025d5d
afdb147
cf80160
a791bf0
3fde4fa
62834e0
2688e19
8a2c683
0e99209
e45924c
2e7b0f7
34382fb
162db7d
4ca2c36
8978b74
a44930b
b28b623
4df0a64
82c6ef0
388543b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you expand this documentation please? What are the units and what is the implication of setting
None
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameslamb This is nice catch, but I think this is beyond of this PR.
precision
was introduced in #1424 and is used in several functions (e.g. inplot_importance()
(#1777)), so I'll address your comment in a separate PR after merging this one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense!