Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code refactoring: cost effective gradient boosting #2407

Merged
merged 11 commits into from
Sep 26, 2019
Merged

code refactoring: cost effective gradient boosting #2407

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c8711d9
refactoring
guolinke Sep 14, 2019
0c6981b
fix style
guolinke Sep 17, 2019
679185f
fix style
guolinke Sep 17, 2019
c8e00d2
Update cost_effective_gradient_boosting.hpp
guolinke Sep 17, 2019
bfc0d2d
Update serial_tree_learner.cpp
guolinke Sep 17, 2019
a56074c
Update serial_tree_learner.h
guolinke Sep 17, 2019
0bc2eda
fix style
guolinke Sep 18, 2019
1754a66
update vc project
guolinke Sep 19, 2019
e97d6e0
Merge branch 'master' into tree_learner_refactoring
guolinke Sep 19, 2019
95c3246
Merge branch 'master' into tree_learner_refactoring
guolinke Sep 23, 2019
9fd1189
Update cost_effective_gradient_boosting.hpp
guolinke Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/treelearner/cost_effective_gradient_boosting.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ class CostEfficientGradientBoosting {
}
}
}
private:

private:
double CalculateOndemandCosts(int feature_index, int real_fidx, int leaf_index) const {
if (tree_learner_->config_->cegb_penalty_feature_lazy.empty()) {
return 0.0f;
Expand Down Expand Up @@ -107,5 +108,5 @@ class CostEfficientGradientBoosting {
std::vector<uint32_t> feature_used_in_data_;
};

} // namespace LightGBM
StrikerRUS marked this conversation as resolved.
Show resolved Hide resolved
} // namespace LightGBM
#endif // LIGHTGBM_TREELEARNER_COST_EFFECTIVE_GRADIENT_BOOSTING_HPP_