-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix many cpp lint errors #2426
fix many cpp lint errors #2426
Conversation
BTW, this will have some conflicts with other PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, amazing! 🎉
I'm only afraid of reinterpret_cast<void*>
: #2064 (comment)
@StrikerRUS yeah, but it seems the reinterpret_cast is the only way, and it actually equals to c style cast. |
@StrikerRUS BTW, as |
@guolinke Yes, but why?.. As it's not a "submodule" (as |
Okay, I think we won't modify it, so we can keep it as it is. However, if these warnings are easy to fix, we could fix it directly. |
refer to #1990