Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed AVX2 from VS config and reset PlatformToolset values back #2731

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Feb 3, 2020

For the reason of removing AVX2 refer to #2699 (comment).

Reset PlatformToolset values back to allow compilation with old versions of MSBuild.
Current behavior after #2699 at Appveyor (image: Visual Studio 2015):

INFO:LightGBM:Starting to compile the library.
INFO:LightGBM:Starting to compile with MSBuild from existing solution file.
WARNING:LightGBM:Compilation with MSBuild from existing solution file failed.
INFO:LightGBM:Starting to compile with Visual Studio 16 2019.
INFO:LightGBM:Starting to compile with Visual Studio 15 2017.
INFO:LightGBM:Starting to compile with Visual Studio 14 2015.
running build
running build_py
creating build

Newer versions should automatically update that values, or we have guide how to change them manually: https://lightgbm.readthedocs.io/en/latest/Installation-Guide.html#with-gui.

@guolinke
Copy link
Collaborator

guolinke commented Feb 3, 2020

sorry, I forgot to update it in my PR

@guolinke guolinke merged commit 5de42f8 into master Feb 3, 2020
@StrikerRUS StrikerRUS deleted the vs_build branch February 4, 2020 22:12
@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants