Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] avoid duplicate AppVeyor builds #3096

Merged
merged 1 commit into from
May 16, 2020

Conversation

jameslamb
Copy link
Collaborator

Currently, we run the same build logic twice on AppVeyor for every commit to master or a branch with a PR into master.

This slows development because on the free tier of AppVeyor we are limited to one build at a time.

In this PR, I propose that we only build once on PRs and on every commit to master. I think this should work per: https://help.appveyor.com/discussions/problems/14586-build-any-pull-requests-against-any-branches.

@jameslamb jameslamb requested review from guolinke and StrikerRUS May 16, 2020 21:23
@jameslamb jameslamb requested a review from Laurae2 as a code owner May 16, 2020 21:23
@jameslamb
Copy link
Collaborator Author

so far so good...only the /pr build for AppVeyor was triggered on this PR!

image

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If one wants to run something at Appveyor before submitting a PR, they can comment these changes in branch_x and trigger test build at Appveyor.

@jameslamb jameslamb merged commit b203bfb into microsoft:master May 16, 2020
@jameslamb
Copy link
Collaborator Author

Can confirm that this worked!

I just merged and we got a master branch build generated on AppVeyor:

image

odimka pushed a commit to odimka/LightGBM that referenced this pull request May 17, 2020
@jameslamb jameslamb deleted the ci/appveyor-pr-only branch June 7, 2020 19:30
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this pull request Jun 10, 2020
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this pull request Jun 11, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants