[R-package] Turn matrix to storage mode "double" #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested changes
Jun 2, 2020
There was a problem hiding this comment.
Thanks for the investigation and PR @mayer79 ! Could you please add a new file R-package/tests/test_Predictor.R and add a unit test on this behavior? Whenever we fix a bug, we should also include tests to be sure we don't re-introduce it in the future.
|
@jameslamb This issue will also solve #3094 |
…de during prediction
|
|
StrikerRUS
changed the title
jameslamb
requested changes
Jun 2, 2020
Co-authored-by: James Lamb <jaylamb20@gmail.com>
jameslamb
approved these changes
Jun 4, 2020
|
thanks for the contribution and for using |
ChipKerchner
pushed a commit
to ChipKerchner/LightGBM
that referenced
this pull request
Jun 10, 2020
* Turn matrix to storage mode "double" * added "test_Predictor.R" to R tests with check for integer storage mode during prediction * Explicit integers in test_Preditor to avoid TravisCI failure * properly aligning comment on storage.mode Co-authored-by: James Lamb <jaylamb20@gmail.com> * split double assignment into two lines Co-authored-by: James Lamb <jaylamb20@gmail.com>
ChipKerchner
pushed a commit
to ChipKerchner/LightGBM
that referenced
this pull request
Jun 11, 2020
* Turn matrix to storage mode "double" * added "test_Predictor.R" to R tests with check for integer storage mode during prediction * Explicit integers in test_Preditor to avoid TravisCI failure * properly aligning comment on storage.mode Co-authored-by: James Lamb <jaylamb20@gmail.com> * split double assignment into two lines Co-authored-by: James Lamb <jaylamb20@gmail.com>
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3139
Just copy-pasted code snippet from lgb.Dataset initalizer.
As I am still not very familiar with the LightGBM data logic, @Laurae2 and @jameslamb would need to confirm that this makes any sense.