-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] Skip tests on 32-bit Windows builds #3302
Conversation
Thanks @jameslamb |
I think we can save condition For example, refer to |
ah! I attached it to the description of the Pr but the link is gone. maybe that doesnt work? Will share it soon. |
@guolinke here you go |
oh, sad news, CRAN is maintaining for now...
|
haha NOOOOOOO 🤣 ok let's come back to this whenever they respond. I'll work on other things not strictly related to CRAN |
@jameslamb maybe we can fix the 32-bit build now. |
sure! I'll add it on #3187 so we can keep the discussion there. |
I think we can close this now, since #3307 makes R CMD check pass on 32-bit Windows 😀 |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This PR proposes skipping all of the R-package tests on 32-bit Windows builds. See the lengthy discussion on #3187, especially this proposal: #3187 (comment).
This PR is an attempt to petition CRAN to allow LightGBM's R package onto CRAN without support for 32-bit Windows, in pursuit of #629 .
I've built this branch and submitted it to win-builder. It passes all automated pre-checks!
This link will work for 72 hours: https://win-builder.r-project.org/YAnUD23bbYGR/
install logs (no issues)
check logs (1 NOTE)
@guolinke could you try submitting this version to CRAN, with something like the proposed text in #3187 (comment)?