Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] added logo to docs #3327

Merged
merged 1 commit into from
Aug 23, 2020
Merged

[docs] added logo to docs #3327

merged 1 commit into from
Aug 23, 2020

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Aug 21, 2020

Added svg versions of logo, also uploaded different (huge-large-medium-small-tiny) versions of png images.

In addition favicon was created.

Everything is located in docs folder to not pollute root folder of the repo.

@jameslamb Seems that pkgdown has special function for favicon generation. Probably it worth to investigate. Also, feel free to add logo at R-package pages in this PR directly or in a separate one.

To test: https://lightgbm.readthedocs.io/en/logo/

image

image


# The name of an image file (relative to this directory) to place at the top of
# the title page.
latex_logo = os.path.join(CURR_PATH, 'logo', 'LightGBM_logo_black_text_small.png')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot use svg for PDF:

! LaTeX Error: Unknown graphics extension: .svg.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be fixed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already "fixed": I'm using png for PDF logo. This my comment was to explain why png is used for PDF but not svg as for HTML.

15. Where can I find LightGBM's logo to use it in my presentation?
------------------------------------------------------------------

You can find LightGBM's logo in different file formats and resolutions `here <https://github.com/microsoft/LightGBM/tree/master/docs/logo>`__.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess linkchecker should fail here due to 404. So this PR should be merged with admin rights with docs test failed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@StrikerRUS
Copy link
Collaborator Author

From mobile:

Screenshot_2020-08-21-03-47-05-614_com android chrome

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will do R in a separate PR

:align: center
:width: 600

|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this | do?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the additional space between logo and heading.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah got it! didn't know you could do that

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants