Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Average precision score #3347

Merged
merged 6 commits into from
Sep 23, 2020
Merged

Average precision score #3347

merged 6 commits into from
Sep 23, 2020

Conversation

btrotta
Copy link
Collaborator

@btrotta btrotta commented Sep 2, 2020

Implement average precision score for binary classification. This is very similar to the precision-recall AUC requested in #3026, but it does not interpolate the points of the curve, since this is not recommended for PR curves (see https://scikit-learn.org/stable/modules/generated/sklearn.metrics.average_precision_score.html).

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/Parameters.rst Outdated Show resolved Hide resolved
@jameslamb jameslamb self-requested a review September 3, 2020 14:29
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me from the R side! I think another reviewer should approve before this is merged though.

@jameslamb
Copy link
Collaborator

@btrotta in case you aren't aware of the practice...I just added the feature label to this so it will be categorized correctly in the next release: https://github.com/microsoft/LightGBM/releases/tag/untagged-bc49d5d1a6b7637e4d22

this is done automatically based on tags by https://github.com/microsoft/LightGBM/blob/master/.github/release-drafter.yml

@btrotta
Copy link
Collaborator Author

btrotta commented Sep 4, 2020

@jameslamb Thanks! I didn't realize the tags were used for the release notes.

@jameslamb
Copy link
Collaborator

no problem!

}

void Init(const Metadata& metadata, data_size_t num_data) override {
name_.emplace_back("ap");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btrotta
Was name left ap (instead of average_precision, #3347 (comment)) intentionally?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this was a mistake, fixed now.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants