Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update list of winning solutions in data science competitions #3358

Merged
merged 3 commits into from
Sep 8, 2020

Conversation

Juniper-23
Copy link
Contributor

Added winning solutions for LightGBM from completed Kaggle Competitions.

@jameslamb
Copy link
Collaborator

jameslamb commented Sep 7, 2020

Thanks @Juniper-23 ! I'm making a few changes to this pull request:

  1. changed the name of the PR to be something that describes what was done (since it will end up in a changelog: https://github.com/microsoft/LightGBM/releases/tag/untagged-1c866fba1430bac197c4
  2. explicitly mentioning that this fixes [docs] update list of winning solutions #3357 so a link will be made between this PR and that issue
  3. merged master into this branch to update the PR

@jameslamb jameslamb changed the title 'examples/README.md' update list of winning solutions in data science competitions Sep 7, 2020
@jameslamb jameslamb added the doc label Sep 7, 2020
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to LightGBM! I've requested a few small changes.

I updated this branch to master, so you should git pull origin changes before making the changes.

examples/README.md Show resolved Hide resolved
@@ -13,6 +13,14 @@ Machine Learning Challenge Winning Solutions
| Place         | Competition   | Solution | Date |
| ------------- |:------------- | --------- | -----|
|1st | [M5 Forecasting - Accuracy](https://www.kaggle.com/c/m5-forecasting-accuracy) | [link](https://www.kaggle.com/c/m5-forecasting-accuracy/discussion/163684) | 2020.6 |
|3rd | [M5 Forecasting - Uncertainty](https://www.kaggle.com/c/m5-forecasting-uncertainty) | [link](https://www.kaggle.com/c/m5-forecasting-uncertainty/discussion/166875) | 2020.7 |
|3rd | [ALASKA2 Image Steganalysis](https://www.kaggle.com/c/alaska2-image-steganalysis) | [link](https://www.kaggle.com/c/alaska2-image-steganalysis/discussion/168870) | 2020.7 |
|1st | [M5 Forecasting - Accuracy](https://www.kaggle.com/c/m5-forecasting-accuracy) | [link](https://www.kaggle.com/c/m5-forecasting-accuracy/discussion/163684) | 2020.6 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please remove this line? This entry already exists in this table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the required changes to the first line of winning solutions. I believe there will be more winning KDD/notebooks. I shall update them sooner.

@StrikerRUS StrikerRUS changed the title update list of winning solutions in data science competitions [docs] update list of winning solutions in data science competitions Sep 7, 2020
@Juniper-23
Copy link
Contributor Author

@jameslamb Thank You, It was my first PR so tried to put together whatever I could figure out on Google regarding contributions. :) I shall do the necessary changes and update ASAP.

@jameslamb
Copy link
Collaborator

no problem! congrats on your first PR and thanks for choosing LightGBM for it.

If you're interested, I have some slides and a recording of a talk I do on how to get started in open source: https://github.com/jameslamb/talks/tree/main/you-can-do-open-source

@Juniper-23
Copy link
Contributor Author

@jameslamb I did go through the slides, found them handy and helpful. Thanks again :) I am yet to watch the video but it would be a really helpful add-on, if some common possible errors that one can comes across with (and their suggestive resolution) while using the git to push/pull code are listed out. I did see that git comes up with nice auto-suggestions that what could have possibly gone wrong but a little bit of google does help. :)

@Juniper-23 Juniper-23 requested a review from jameslamb September 7, 2020 21:51
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, thanks very much! I'm going to merge this, but we'd welcome other contributions to keep updating this list (https://github.com/microsoft/LightGBM/pull/3358/files#r484571297)

@jameslamb jameslamb merged commit d3fb6c9 into microsoft:master Sep 8, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants