improve subfeature_bynode #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
commented
Sep 12, 2020
| @@ -702,9 +702,6 @@ void SerialTreeLearner::ComputeBestSplitForFeature( | |||
| FeatureHistogram* histogram_array_, int feature_index, int real_fidx, | |||
| bool is_feature_used, int num_data, const LeafSplits* leaf_splits, | |||
| SplitInfo* best_split) { | |||
| if (!is_feature_used) { | |||
| return; | |||
| } | |||
| SplitInfo new_split; | |||
| double parent_output; | |||
| if (leaf_splits->leaf_index() == 0) { | |||
There was a problem hiding this comment.
@btrotta it seems the parent output is calculated repeatedly here for root node. I think this cost could be reduced.
guolinke
commented
Sep 12, 2020
This was referenced Sep 12, 2020
guolinke
commented
Sep 12, 2020
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is useful to filter the histogram that cannot split.