-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new GPU docker files #3408
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
# Copyright (c) 2020 The Rector and Visitors of the University of Virginia | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated | ||
# documentation files (the "Software"), to deal in the Software without restriction, including without | ||
# limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the | ||
# Software, and to permit persons to whom the Software is furnished to do so, subject to the following | ||
# conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included in all copies or substantial portions | ||
# of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED | ||
# TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF | ||
# CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER | ||
# DEALINGS IN THE SOFTWARE. | ||
|
||
FROM nvidia/opencl:devel AS build | ||
ARG DEBIAN_FRONTEND=noninteractive | ||
ARG OPENCL_LIBRARIES=/usr/lib/x86_64-linux-gnu | ||
ARG OPENCL_INCLUDE_DIR=/usr/include/CL | ||
|
||
# SYSTEM | ||
RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
build-essential \ | ||
git \ | ||
ca-certificates \ | ||
libglib2.0-0 \ | ||
libxext6 \ | ||
libsm6 \ | ||
libxrender1 \ | ||
cmake \ | ||
libboost-dev \ | ||
libboost-system-dev \ | ||
libboost-filesystem-dev \ | ||
gcc \ | ||
g++ && \ | ||
rm -rf /var/lib/apt/lists/* | ||
|
||
# LightGBM | ||
WORKDIR /opt | ||
RUN git clone --recursive --branch stable --depth 1 https://github.com/Microsoft/LightGBM && \ | ||
cd LightGBM && mkdir build && cd build && \ | ||
cmake -DUSE_GPU=1 -DOpenCL_LIBRARY=${OPENCL_LIBRARIES}/libOpenCL.so.1 -DOpenCL_INCLUDE_DIR=$OPENCL_INCLUDE_DIR .. && \ | ||
make OPENCL_HEADERS=$OPENCL_INCLUDE_DIR LIBOPENCL=$OPENCL_LIBRARIES | ||
|
||
FROM gcr.io/distroless/cc-debian10 | ||
COPY --from=build \ | ||
/opt/LightGBM/lightgbm \ | ||
/opt/LightGBM/lib_lightgbm.so \ | ||
/opt/LightGBM/ | ||
COPY --from=build \ | ||
/usr/lib/x86_64-linux-gnu/libOpenCL.so.1 \ | ||
/usr/lib/x86_64-linux-gnu/libboost_filesystem.so.1.65.1 \ | ||
/usr/lib/x86_64-linux-gnu/libboost_system.so.1.65.1 \ | ||
/usr/lib/x86_64-linux-gnu/libgomp.so.1 \ | ||
/usr/lib/x86_64-linux-gnu/libstdc++.so.6 \ | ||
/usr/lib/x86_64-linux-gnu/ | ||
COPY --from=build \ | ||
/lib/x86_64-linux-gnu/libm.so.6 \ | ||
/lib/x86_64-linux-gnu/libgcc_s.so.1 \ | ||
/lib/x86_64-linux-gnu/libpthread.so.0 \ | ||
/lib/x86_64-linux-gnu/libc.so.6 \ | ||
/lib/x86_64-linux-gnu/libdl.so.2 \ | ||
/lib/x86_64-linux-gnu/ | ||
COPY --from=build \ | ||
/lib64/ld-linux-x86-64.so.2 \ | ||
/lib64/ | ||
COPY --from=build /etc/OpenCL/vendors/nvidia.icd /etc/OpenCL/vendors/nvidia.icd | ||
|
||
ENV PATH /opt/LightGBM:${PATH} | ||
ENV LANG C.UTF-8 | ||
ENV LC_ALL C.UTF-8 | ||
|
||
LABEL maintainer=rs7wz@virginia.edu | ||
|
||
ENTRYPOINT ["lightgbm"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
# Copyright (c) 2020 The Rector and Visitors of the University of Virginia | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated | ||
# documentation files (the "Software"), to deal in the Software without restriction, including without | ||
# limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the | ||
# Software, and to permit persons to whom the Software is furnished to do so, subject to the following | ||
# conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included in all copies or substantial portions | ||
# of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED | ||
# TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF | ||
# CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER | ||
# DEALINGS IN THE SOFTWARE. | ||
|
||
FROM nvidia/opencl:devel AS build | ||
ARG DEBIAN_FRONTEND=noninteractive | ||
ARG OPENCL_LIBRARIES=/usr/lib/x86_64-linux-gnu | ||
ARG OPENCL_INCLUDE_DIR=/usr/include/CL | ||
|
||
# SYSTEM | ||
RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
build-essential \ | ||
git \ | ||
ca-certificates \ | ||
libglib2.0-0 \ | ||
libxext6 \ | ||
libsm6 \ | ||
libxrender1 \ | ||
cmake \ | ||
libboost-dev \ | ||
libboost-system-dev \ | ||
libboost-filesystem-dev \ | ||
gcc \ | ||
g++ && \ | ||
rm -rf /var/lib/apt/lists/* | ||
|
||
# LightGBM | ||
WORKDIR /opt | ||
RUN git clone --recursive --branch stable --depth 1 https://github.com/Microsoft/LightGBM && \ | ||
cd LightGBM && mkdir build && cd build && \ | ||
cmake -DUSE_GPU=1 -DOpenCL_LIBRARY=${OPENCL_LIBRARIES}/libOpenCL.so.1 -DOpenCL_INCLUDE_DIR=$OPENCL_INCLUDE_DIR .. && \ | ||
make OPENCL_HEADERS=$OPENCL_INCLUDE_DIR LIBOPENCL=$OPENCL_LIBRARIES | ||
|
||
FROM nvidia/opencl:runtime | ||
RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
libxext6 \ | ||
libsm6 \ | ||
libxrender1 \ | ||
libboost-system-dev \ | ||
libboost-filesystem-dev \ | ||
gcc \ | ||
g++ && \ | ||
rm -rf /var/lib/apt/lists/* | ||
|
||
COPY --from=build \ | ||
/opt/LightGBM/lightgbm \ | ||
/opt/LightGBM/lib_lightgbm.so \ | ||
/opt/LightGBM/ | ||
|
||
ENV PATH /opt/LightGBM:${PATH} | ||
ENV LANG C.UTF-8 | ||
ENV LC_ALL C.UTF-8 | ||
|
||
LABEL maintainer=rs7wz@virginia.edu | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since this code is being brought into LightGBM, I think that this label should be removed. If users have issues with this Dockerfile, it'll be LightGBM maintainers fixing it, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right, please feel free to edit the Dockerfile! (It was copied directly from our repo.) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was confused by this line just like you @jameslamb! But I googled a little bit, and it seems that in Docker world
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh ok, I see. I think that we can just remove the label completely. I just don't want someone with an issue to send an email there instead of opening an issue in this repo, especially since after this PR is merge we might make other changes as LightGBM evolves There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, removed in a9d85c3 (also replaced tabs with whitespaces). |
||
|
||
ENTRYPOINT ["lightgbm"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we apply this patch for this image?
LightGBM/docker/gpu/dockerfile.gpu
Lines 59 to 61 in df37bce
https://github.com/microsoft/LightGBM/pull/3408/files#diff-1dd8c717ecdb4eb66c585ba89bbc2649R69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For distroless image: The file should be included in the
nvidia/opencl:devel
base image already, so in Line 69 I just simply copied the file:For opencl image: The file should be present in the
nvidia/opencl:runtime
base image that's used in the final stage.The patch is necessary for the dockerfile based on
nvidia/cuda
because it doesn't have all the OpenCL stuff.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! Thanks for the detailed response!