Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-package] [ci] Add test on R package with sanitizers #3439

Merged
merged 21 commits into from
Oct 9, 2020
Merged

[R-package] [ci] Add test on R package with sanitizers #3439

Changes from 20 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
03b9032
[ci] add R CI job with UBSAN
jameslamb Sep 29, 2020
c2b264b
stuff
jameslamb Sep 29, 2020
4d1ffb9
fix command
jameslamb Sep 30, 2020
231ca27
stuff
jameslamb Sep 30, 2020
44aabab
update template
jameslamb Oct 3, 2020
29d121d
fail on errors
jameslamb Oct 3, 2020
d8ffbbe
spaces
jameslamb Oct 6, 2020
c61fab0
trigger by comment
jameslamb Oct 6, 2020
bc4df98
stuff
jameslamb Oct 6, 2020
b462ea9
Merge branch 'master' into ci/r-ubsan-gcc
jameslamb Oct 6, 2020
0ffb520
add all CI back
jameslamb Oct 6, 2020
9a4b11e
trying things
jameslamb Oct 6, 2020
0d22def
run sanitizers as a regular job
jameslamb Oct 7, 2020
7b71fd2
remove comments
jameslamb Oct 7, 2020
ea24d06
sanitizers
jameslamb Oct 7, 2020
c6503bc
try to trigger UBSAN
jameslamb Oct 7, 2020
6018aa2
try to trigger failure
jameslamb Oct 8, 2020
55ec1ee
remove int overflow
jameslamb Oct 8, 2020
bc1b107
Merge branch 'master' into ci/r-ubsan-gcc
jameslamb Oct 8, 2020
4e098a0
remove testing change
jameslamb Oct 8, 2020
e5cf2c9
Apply suggestions from code review
jameslamb Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion .github/workflows/r_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,35 @@ jobs:
$env:TASK = "${{ matrix.task }}"
conda init powershell
& "$env:GITHUB_WORKSPACE/.ci/test_windows.ps1"
test-r-sanitizers:
name: r-package (ubuntu-latest, R-devel, GCC ASAN/UBSAN)
timeout-minutes: 60
runs-on: ubuntu-latest
container:
image: rhub/rocker-gcc-san
steps:
- name: Checkout repository
uses: actions/checkout@v1
with:
fetch-depth: 5
submodules: true
- name: install
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
shell: bash
run: |
Rscript -e "install.packages(c('R6', 'data.table', 'jsonlite', 'testthat'), repos = 'http://cran.r-project.org')"
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
sh build-cran-package.sh
Rdevel CMD INSTALL lightgbm_*.tar.gz
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
- name: test
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
shell: bash
run: |
cd R-package/tests
Rscriptdevel testthat.R 2>&1 > ubsan-tests.log
cat ubsan-tests.log
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it left intentionally or it was for debugging purposes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it in intentionally, so that if the job fails you have enough logs to be able to tell what went wrong

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

exit $(cat ubsan-tests.log | grep "runtime error" | wc -l)
all-successful:
# https://git.luolix.topmunity/t/is-it-possible-to-require-all-github-actions-tasks-to-pass-without-enumerating-them/117957/4?u=graingert
runs-on: ubuntu-latest
needs: [test]
needs: [test, test-r-sanitizers]
steps:
- name: Note that all tests succeeded
run: echo "🎉"