[R-package] remove deprecation warnings on lgb.prepare() functions #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
approved these changes
Oct 17, 2020
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
LightGBM3.0.0, thelgb.prepare*family of functions were removed (#3075 , #3095). That release still technically left those functions in{lightgbm}, but had them throw an error encouraging the use oflgb.convert()andlgb.convert_with_rules().This PR proposes removing those functions completely. It's been more than a month since
LightGBM3.0.0, so I think the deprecation has been in the package long enough.Removing these functions should slightly reduce the time it takes to build, install, and test the R package, and slightly reduce the size of the installed package.