-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] ignore R CMD CHECK warnings on new R version #3468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Seems that it is more complicated:
|
maybe I can turn off this specific warning with an environment variable. That would be better than allowing up to 1 warning in CI. I'll investigate |
Yes, definitely! |
it looks like we can not skip this check 😢 I don't see any environment variables mentioned in the relevant code for I also tried to look for all of the environment variables that control https://github.com/wch/r-source/search?q=Sys.getenv I'm going to ask the |
ok I've updated the versions to R 4.0.3 |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
In CI for the R package, we check for
R CMD CHECK
warnings by looking for the string "warning" in its logs. That test is currently breaking builds (https://github.com/microsoft/LightGBM/runs/1268855023) for a warning that can safely be ignored:This PR proposes ignoring those warnings. It also slightly simplifies the config for the UBSAN tests added in #3439 (based on #3443 (comment))