Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update MacOS version at Travis #3505

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Conversation

nabokovas
Copy link
Contributor

There is a new version of The macOS Build Environment. So I propose changes for you to use a modern one. https://docs.travis-ci.com/user/reference/osx/

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to contribute! But I'm -1 on this change.

We do try to test LightGBM against somewhat-reason versions of software, but we also want to be sure that the library works well on widely-used configurations. XCode 12.2 is less than a month old (https://xcodereleases.com/), so I'd guess that many of our users who are using LightGBM on Mac haven't updated to it.

But I'll defer to @StrikerRUS 's opinion

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabokovas Thank you very much for this update! You've just done my job 🙂

@jameslamb Let me kindly disagree with you. According to our policy, we try to use the most recent environments at Travis (#3393 (comment)) and update them quite often. I remember, we even used betas.

image

I believe it's better to spot a compilation problem at our CI before users come and report it.
Moreover, we are speaking about macOS where it seems users tend to use the last available software in contrast to Linux where one have to use 10-years old CentOS distribution.

FYI, yesterday I tried to use Big Sur, but unfortunately without any luck due to dependency unavailability: #3499.

@StrikerRUS StrikerRUS changed the title Update MacOS version [ci] Update MacOS version at Travis Oct 29, 2020
@jameslamb
Copy link
Collaborator

ah I see, ok then I am ok with this change.

@jameslamb jameslamb self-requested a review October 30, 2020 00:04
@StrikerRUS StrikerRUS merged commit f4b9519 into microsoft:master Oct 30, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants