[R-package] fix typo in linear learner test #4109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a typo in params on one of the R unit tests, which led to the warning noted in #4105 (comment)
That test specifically checks that training a model in R using linear models at the leaves works if you also have categorical features. So this typo might have actually prevented that test from running correctly and covering what it was expected to.
I also looked through the logs from a recent build of the
r-package (windows-2019, MSVC, R 4, cmake)
CI job. Those jobs useRscript testthat.R
instead ofR CMD CHECK
, so you can see all of the logs from the tests. For the other warnings that look problematic, I've opened #4108 with the taggood first issue
so that it might be addressed by other contributors.