Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal Varianсe Sampling booster #4266
Minimal Varianсe Sampling booster #4266
Changes from 14 commits
1af3f3e
0ad2740
08462f9
b067a5b
8229008
0f2620e
d50769e
f531f3a
ef1a28c
c610035
4425874
a5b72f8
64a99f4
fb8ff6e
d499d15
8a01fb8
4b630a1
29fc099
49ed4eb
d018ed0
d62c98c
8cee27e
224ac05
5cd4422
468102b
fd3f64a
11df789
b489b66
bab99b3
ddcab83
31ab4d4
9ce06ae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we change
num_leaves
to beconfig_->num_leaves
instead of the number of leaves of the first tree? If there's a tree with more leaves than the first one, then the extra leaves will be ignored.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need_re_bagging_
should be set tofalse
if theBagging
is actually carried out, to make it consistent with the behavior in the default random sampling. Please check the code snippet below.LightGBM/src/boosting/gbdt.cpp
Lines 228 to 233 in 08c38ef