-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] [R-package] increase timeout on valgrind job #4397
Conversation
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: failure ❌. |
This job is failing with an error message that suggests that the job config is being sourced from
https://github.com/microsoft/LightGBM/actions/runs/959283121 (notice that it says "120 minutes") @StrikerRUS , does that mean this needs to be merged to be tested? |
Yes, you're right. LightGBM/.github/workflows/r_valgrind.yml Lines 3 to 5 in 4720889
With repository_dispatch event trigger, workflow config is taken from the default branch (master in our case).https://docs.github.com/en/actions/reference/events-that-trigger-workflows#repository_dispatch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Do you have rights to merge this PR with failing test? |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
See #4391 (comment) and this failed job with a timeout of 180 minutes (https://github.com/microsoft/LightGBM/actions/runs/959047226).
It seems recently-added R package tests (or maybe some combination of that and changes in the C++ side) has led to the valgrind jobs exceeding 120 minutes. As a reminder, R runs substantially slower under valgrind (https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Using-valgrind).