Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Use the latest gcc version in macOS CI jobs #4640

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Conversation

StrikerRUS
Copy link
Collaborator

Noticed the following in our logs:

...

Warning: gcc 11.2.0 is already installed and up-to-date.
To reinstall 11.2.0, run:
  brew reinstall gcc

...

-- The C compiler identification is GNU 10.3.0
-- The CXX compiler identification is GNU 10.3.0

...

GitHub Actions macOS image has multiple preinstalled gcc versions.

gcc-9 (Homebrew GCC 9.4.0) 9.4.0 - available by gcc-9 alias
gcc-10 (Homebrew GCC 10.3.0) 10.3.0 - available by gcc-10 alias
gcc-11 (Homebrew GCC 11.2.0) 11.2.0 - available by gcc-11 alias
https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#language-and-runtime

This is why our master is not failing with these lines

LightGBM/.ci/test.sh

Lines 3 to 5 in a77260f

if [[ $OS_NAME == "macos" ]] && [[ $COMPILER == "gcc" ]]; then
export CXX=g++-10
export CC=gcc-10

@StrikerRUS
Copy link
Collaborator Author

With this PR we compile LightGBM with gcc-11 on macOS:

...

-- The C compiler identification is GNU 11.2.0
-- The CXX compiler identification is GNU 11.2.0

...

@StrikerRUS
Copy link
Collaborator Author

Also everything is OK according to the logs with swapped compilers: bc2f8ce.

@StrikerRUS StrikerRUS changed the title [WIP] Use the latest gcc version in macOS CI jobs [ci] Use the latest gcc version in macOS CI jobs Oct 3, 2021
@StrikerRUS StrikerRUS marked this pull request as ready for review October 3, 2021 01:19
@StrikerRUS StrikerRUS requested a review from jameslamb as a code owner October 3, 2021 01:19
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, yeah I support this! Thanks for looking into it.

@StrikerRUS StrikerRUS merged commit 01aa295 into master Oct 5, 2021
@StrikerRUS StrikerRUS deleted the bump_gcc branch October 5, 2021 21:17
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants