Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] ignore certificates for kitware apt channel in CUDA jobs (fixes #4646) #4648

Merged
merged 3 commits into from
Oct 4, 2021
Merged

[ci] ignore certificates for kitware apt channel in CUDA jobs (fixes #4646) #4648

merged 3 commits into from
Oct 4, 2021

Conversation

jameslamb
Copy link
Collaborator

Attempts to fix the blocking CI issue on CUDA jobs (#4646). See that issue for more investigation.

Basically, I believe that the nvidia/cuda images (last updated 9/20/2021) are using a client somewhere that is using one or more certificates relying on the Let's Encrypt root certificate that expired 9/30/2021.

This PR patches .ci/setup.sh to say "just trust the kitware apt repository and don't check it's certificate" for CUDA jobs.

Notes for Reviewers

I'm going to open an issue later today on the issues page for the nvidia/cuda images, asking them to update their images. But at least for now, I hope this PR will unblock LightGBM's CI.

@jameslamb
Copy link
Collaborator Author

Looks like #4645 (Eigen being unavailable from GitLab) has not been addressed by GitLab yet 🙃

remote: A repository for this project does not exist yet.
Error: fatal: repository 'https://gitlab.com/libeigen/eigen.git/' not found
Error: fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/home/guoke/actions-runner/_work/LightGBM/LightGBM/external_libs/eigen' failed
Failed to clone 'external_libs/eigen'. Retry scheduled

https://github.com/microsoft/LightGBM/pull/4648/checks?check_run_id=3792108299

@jameslamb jameslamb changed the title [ci] ignore certificates for kitware apt channel in CUDA jobs (fixes #4646) WIP: [ci] ignore certificates for kitware apt channel in CUDA jobs (fixes #4646) Oct 4, 2021
jameslamb
jameslamb commented Oct 4, 2021
View reviewed changes
.gitmodules Outdated
@@ -3,7 +3,7 @@
url = https://github.com/boostorg/compute
[submodule "eigen"]
path = external_libs/eigen
url = https://gitlab.com/libeigen/eigen.git
url = https://gitlab.com/cantonios/eigen.git
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely not recommending this change, as I don't think LightGBM should depend on unofficial sources for submodules.

Just doing this (following the suggestion from https://gitlab.com/libeigen/eigen/-/issues/2336#note_693188875) to at least be able to test if the changes in this PR do resolve the CUDA issues

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url = https://gitlab.com/cantonios/eigen.git
url = https://gitlab.com/libeigen/eigen.git

Seems from https://gitlab.com/libeigen/eigen/-/issues/2336#note_694339283 that the main Eigen repo is back.

StrikerRUS
StrikerRUS approved these changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for working on this!
Looks like everything is working now 🎉

@jameslamb jameslamb changed the title WIP: [ci] ignore certificates for kitware apt channel in CUDA jobs (fixes #4646) [ci] ignore certificates for kitware apt channel in CUDA jobs (fixes #4646) Oct 4, 2021
@jameslamb jameslamb marked this pull request as ready for review October 4, 2021 22:14
@StrikerRUS StrikerRUS merged commit 10e0edc into master Oct 4, 2021
@StrikerRUS StrikerRUS deleted the ci/fix-cuda-jobs branch October 4, 2021 22:35
@StrikerRUS
Copy link
Collaborator

I'm going to open an issue later today on the issues page for the nvidia/cuda images, asking them to update their images.

Thanks! I hope we'll be able to revert this our PR soon.

@StrikerRUS StrikerRUS mentioned this pull request Dec 11, 2021
Merged
StrikerRUS added a commit that referenced this pull request Jan 22, 2022
@StrikerRUS
Revert "[ci] ignore certificates for kitware apt channel in CUDA jobs (…
3dc8838 
…fixes #4646) (#4648)"

This reverts commit 10e0edc.
@StrikerRUS StrikerRUS mentioned this pull request Jan 23, 2022
Merged
StrikerRUS added a commit that referenced this pull request Jan 23, 2022
@StrikerRUS
[ci] bump CUDA version from 11.5.0 to 11.5.1 at CI (#4967)
0075814 
* Revert "[ci] ignore certificates for kitware apt channel in CUDA jobs (fixes #4646) (#4648)"

This reverts commit 10e0edc.

* update cuda at CI
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StrikerRUS StrikerRUS StrikerRUS approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @StrikerRUS