-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Run Linux OpenCL tests against POCL instead of the AMD App SDK #5282
Conversation
Here is the reason why they are disabled: #3708 (comment). I think for this PR we shouldn't enable them to not delay #5252. In a follow-up PR we'll definitely try to re-enable them and run multiple times to ensure their stability. |
How about Windows, is PoCL available there? |
Could you please update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this PR!
Just some minor comments below.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
It's available, but unfortunately not as an ICD, which means that we wouldn't be able to test the integrated OpenCL builds, and that the other OpenCL builds would not test something representative. |
OK, got it! Thank you for the explanation. |
I have updated the |
Given this your previous comment #5282 (comment), this sounds reasonable. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks so much!
Love this change, thanks very much for all the hard work @jgiannuzzi ! |
Unfortunately, with PoCL Dask tests fail with |
My understanding is that the On Ubuntu 20.04, the tests seem to fail because of a timeout. Enabling those tests on a fake GPU is expected to take more time. Maybe setting I'm happy to create a PR for this if you'd like. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
As discussed in #5252 (comment), I think that using PoCL for the Linux
gpu
tests would make a lot of sense, as it is open source and actively maintained, as opposed to the AMD App SDK.The
dask
tests are currently disabled for thegpu
task, but they in my local testing the do succeed with PoCL. Should we maybe (re-)enable them?