Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] [python-package] correct tag on x86_64 wheels #5598

Merged
merged 2 commits into from
Nov 27, 2022
Merged

Conversation

jameslamb
Copy link
Collaborator

Contributes to #4788.

#5580 switched LightGBM's CI to using an image based on pypa/manylinux_2_28_x86_64 to produce x86_64 wheels.

In that PR, I forgot to update the platform tag used with those wheels 😬

This PR contains two fixes:

Notes for Reviewers

In a future PR, I think we should consider running auditwheel show in CI like @tdoublep did in #4788, to prevent this "wrong tag" issue from making it onto master.

@jameslamb jameslamb added the fix label Nov 21, 2022
@jameslamb jameslamb changed the title WIP: [ci] [python-package] correct tag on x86_64 wheels [ci] [python-package] correct tag on x86_64 wheels Nov 21, 2022
@jameslamb jameslamb marked this pull request as ready for review November 21, 2022 14:25
@jameslamb jameslamb mentioned this pull request Nov 25, 2022
60 tasks
@jameslamb
Copy link
Collaborator Author

@jmoralez @shiyu1994 @guolinke could you help with reviews of this one and #5590 ? These contribute to my ongoing effort to stabilize the CI and ensure the Python package is still installable after pip v23.1 comes out (#5061 ).

Thank you!

@jameslamb
Copy link
Collaborator Author

Thanks for the review, @jmoralez !

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants