Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] correctly quote paths on Windows for CMake-based builds #5607

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

jameslamb
Copy link
Collaborator

Contributes to #5135.

I have a Windows laptop running Windows 10. It has an NVIDIA GeForce 840M GPU.

Software:

  • R 4.2.1
  • Rtools42
  • CUDA Tookit 11.8 (link)

On latest master, running the following results in the unexpected symbol error reported in #5135.

Rscript build_r.R \
    --use-gpu \
    --boost-root="C:\Users\James\repos\LightGBM\external_libs\compute" \
    --no-build-vignettes \
    --use-msys2

With the changes on this branch, {lightgbm} compiles successfully.

Notes for Reviewers

This does not fix the other issue reported in #5135 (that CMake always finds the Boost bundled with RTools42). But it at least fixes how paths are handled and passed through build_r.R.

@jameslamb jameslamb added the fix label Nov 28, 2022
@jameslamb jameslamb changed the title WIP: [R-package] correctly quote paths on Windows for CMake-based builds [R-package] correctly quote paths on Windows for CMake-based builds Nov 28, 2022
@jameslamb jameslamb marked this pull request as ready for review November 28, 2022 04:50
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants