-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] fix mypy errors about missing annotations and incompatible types #5672
Merged
jameslamb
merged 14 commits into
microsoft:master
from
IdoKendo:python-package/fix-mypy-errors
Mar 9, 2023
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e228ff2
[python-package] fix mypy errors about missing annotations and incomp…
IdoKendo f9390f2
[python-package] move mypy fixes for eval_at and basic to a seperate …
IdoKendo 18f35d0
Merge branch 'microsoft:master' into python-package/fix-mypy-errors
IdoKendo d8f15bb
Merge branch 'microsoft:master' into python-package/fix-mypy-errors
IdoKendo 222a92e
[python-package] move mypy fixes for predict to a seperate commit
IdoKendo 5487ca5
Merge branch 'microsoft:master' into python-package/fix-mypy-errors
IdoKendo 4c76974
Revert change that was fixed in another PR
IdoKendo 6a1c593
Move predict_proba() fix to a different PR
IdoKendo e079742
Merge branch 'master' into python-package/fix-mypy-errors
IdoKendo c94ccb5
Revert redundant changes
IdoKendo 4cb3474
Merge branch 'microsoft:master' into python-package/fix-mypy-errors
IdoKendo 9ac356b
Merge branch 'microsoft:master' into python-package/fix-mypy-errors
IdoKendo 5fab4fb
[python-package] Move None type hint from _EvalResultTuple
IdoKendo f773330
[python-package] move refactor to another branch
IdoKendo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't include
None
in this type hint. That makes it difficult to use in other parts of the code whereNone
isn't a valid value.