[python-package] add type hints on plotting code #5708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3756.
Adds type hints on most other places in
python-package/plotting.py
that were missing them.Also proposes some other changes that I feel make it easier to follow the flow of data through that module (which I think is closely related to the goal of adding type hints).
plotting._to_graphviz()
Notes for Reviewers
I might propose a change similar to #5704 (moving
add()
up to the module level so it isn't redefined every time_to_graphviz()
is called) in a future PR, but decided not to do that here so that it was clear, from inspecting at the diff, what I'm proposing changing with type hints and keywords arguments.