Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] remove OpenMP / MKL workaround in CI jobs #6496

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Jun 21, 2024

Proposes removing a workaround in CI scripts that has been in place since #1606.

The code removed here sets up some symlinks that make it look like, for example, libgomp.dylib (GNU OpenMP) is libomp.dylib (the SONAME used by LLVM OpenMP). This was a workaround for some conflicts between OpenMP implementations that were showing up together (I think).

Removing it to simplify CI scripts, and because:

  • it should no longer be necessary (since [ci] [python-package] add arm64 macOS wheels #6391 prevents LightGBM from loading another libomp.dylib into an process that already has one loaded)
  • this workaround risks LightGBM accidentally linking against a library we don't intend for it to link against
    • (e.g. macOS wheels should be linked against libomp, LLVM OpenMP)

Notes for Reviewers

For more conversation on this, see #6489.

@jameslamb jameslamb changed the title WIP: [ci] remove OpenMP / MKL workaround in CI jobs [ci] remove OpenMP / MKL workaround in CI jobs Jun 21, 2024
@jameslamb jameslamb marked this pull request as ready for review June 21, 2024 06:04
@jameslamb jameslamb merged commit c4e70f3 into master Jun 21, 2024
41 checks passed
@jameslamb jameslamb deleted the ci/remove-omp-workarond branch June 21, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants