-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU] Add support for linear tree with device=gpu #6567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dragonbra Thanks a lot for your contribution!
I checked that there are no any other differences except "gpu_" prefixes in new files compared to original linear_tree_learner.h
and linear_tree_learner.cpp
.
I don't think that my review should be count to allow the merge. But I left one wording suggestion and would like to ask you add new files in LightGBM.vcxproj
and LightGBM.vcxproj.filters
: https://github.com/microsoft/LightGBM/tree/master/windows.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Hi, I checked the files |
@dragonbra Thanks for checking this! Indeed, there are no any |
|
||
namespace LightGBM { | ||
|
||
void GPULinearTreeLearner::Init(const Dataset* train_data, bool is_constant_hessian) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the solution looks good to me. I've read half of the implementation and need some more time to check the correctness. Thank you.
For test case, I think the test case for this scenario is automatically enabled with existing test cases for linear trees and device_type=gpu
.
Given the redundancy in |
Thank you very much for simplifying this to reduce the code duplication @shiyu1994 ! |
GPU version's implementation refer to issue #6555