[python-package] update to scikit-build-core 0.10 #6597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
commented
Aug 9, 2024
| build-backend = "scikit_build_core.build" | ||
|
|
||
| # based on https://github.com/scikit-build/scikit-build-core#configuration | ||
| [tool.scikit-build] | ||
|
|
||
| cmake.version = ">=3.28" | ||
| cmake.version = "CMakeLists.txt" |
There was a problem hiding this comment.
This is described in the blog post linked in the PR... scikit-build-core now reads cmake_minimum_required() from CMakeLists.txt and uses it to figure this out. So no more need to keep those 2 versions in sync!
I'm not sure how this would work if cmake_minimum_required() varied based on options, as this project used to do prior to #6260 .... but I hope we'll not have to go back to that in the future and can just keep having a single minimum version.
jameslamb
commented
Aug 9, 2024
| @@ -80,7 +80,7 @@ sdist.reproducible = true | |||
| wheel.py-api = "py3" | |||
| experimental = false | |||
| strict-config = false | |||
| minimum-version = "0.9.3" | |||
| minimum-version = "build-system.requires" | |||
There was a problem hiding this comment.
Another case where scikit-build-core is reducing the need for us to keep the same version in sync across 2 fields.
Setting scikit-build-core>=0.10.1 is equivalent to setting this to minimum-version = "0.10.1" 😁
jameslamb
changed the title
jameslamb
requested review from
guolinke,
shiyu1994,
jmoralez,
borchero and
StrikerRUS
as code owners
StrikerRUS
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new
sckit-build-coreminor version with lots of nice improvements. This proposes updating to it here in LightGBM.See https://iscinumpy.dev/post/scikit-build-core-0-10/ for details.