-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] check PowerShell scripts with PSScriptAnalyzer #6700
Conversation
This PR looks quite big for reviewing. I think it's better to split it into several smaller PRs. @jameslamb WDYT? |
I agree @StrikerRUS , I think it'd be better as separate PRs. How about just 2? First PR:
Second PR:
If that's too difficult, then I'm happy to follow any sequence you want and I'll try to provide reviews quickly. But at a minimum I think the first PR should introduce the |
@jameslamb Yeah, sure! I'll split this PR into 2 or 3 smaller ones that will be comfortable to review. |
Fixed #6498.
Fix reported warnings from #6498 (comment) and new ones from non-default rules.