-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] add note about pyodide support #6715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Interesting project indeed! I have never heard about it before.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Thanks for the note! Would y'all consider helping us where you can by adding a few representatives/core developers/maintainers as maintainers for LightGBM's recipe? This way, users would know who to ping in case they face issues with running LightGBM in Pyodide, and we can reach out when we face troubles with updating its version. In case there are concerns about the time required to spend on this – neither of these things should be a frequent occurrence; we usually update versions periodically when we are close to a new release or when we bump the Emscripten version and break the ABI (around twice a year). |
FYI, I also noted #5372 – which is a topic that Pyodide resolves by providing LightGBM to run in WASM environments. An out-of-tree CI job for Pyodide as a target could prove to be useful, see: https://pyodide.org/en/latest/development/building-and-testing-packages.html |
You can add my GitHub handle as a start, I will try to help when I can. Will leave it to other maintainers here to tell you if they'd like to be added.
Please comment on that issue with links to any relevant examples that someone finding it from search (or subscribed to notifications) could use to understand how to use pyodide to run LightGBM in WASM. Then we can close that on the feature tracker.
Thanks for that link. This is the first time I've heard the phrase "out of tree", and to be honest I don't totally understand what you mean. Are you asking us to start building WASM wheels and uploading them to https://pypi.org/project/lightgbm/? If so... what's the benefit of doing that when pyodide is already maintaining |
Thank you for volunteering, @jameslamb – I'll do both of those things!
No, PyPI does not support uploads WASM wheels yet, unfortunately. That would require a PEP, which I don't think we will be able to find a sponsor for in near time. We currently host WASM wheels for all the packages we are able to build for on our own with an interface via the JSDelivr CDN, thereby providing an entire "distribution" of CPython for WASM rather than just an "implementation". To answer your question more specifically: yes, we do maintain |
Ah great, thanks for that explanation! I'm willing to try this at some point, and we can see how much maintenance effort it is to set up and maintain. Let's use #5372 to track that work. I think it won't be a high near-term priority for us, but something I'd like to eventually try adding. Until then, you can
Thanks for explicitly calling this out, it might have taken a while for me to discover! We do support a 32-bit build, but only on Windows: Lines 138 to 142 in 6e0b0a8
But don't test that configuration in CI. |
This is SO COOL .... I learned tonight that Pyodide is building a version of the
lightgbm
Python package that runs in a web browser.https://github.com/pyodide/pyodide/tree/main/packages/lightgbm
Try it yourself.... go to https://pyodide.org/en/stable/console.html (recommended from https://pyodide.org/en/stable/usage/index.html), and run the following:
🤯 🤯 🤯 🤯
This proposes adding a note about that to the README.