Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] fixed sklearn test on python 2.7 #888

Merged
merged 5 commits into from
Sep 5, 2017
Merged

[python] fixed sklearn test on python 2.7 #888

merged 5 commits into from
Sep 5, 2017

Conversation

StrikerRUS
Copy link
Collaborator

Refer to #880 (comment)

@msftclas
Copy link

msftclas commented Sep 4, 2017

@StrikerRUS,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@wxchan
Copy link
Contributor

wxchan commented Sep 5, 2017

Actually I don't think we need to check num of deprecated warnings.

@StrikerRUS
Copy link
Collaborator Author

@wxchan Remain only check that seed and random_state internally are the same and remove check for "warnings were raised"?

@wxchan
Copy link
Contributor

wxchan commented Sep 5, 2017

@StrikerRUS yes, what do you think?

@StrikerRUS
Copy link
Collaborator Author

@wxchan I agree. Anyway, in the future warnings will be deleted and "warnings were raised" check correspondingly too.

@guolinke guolinke merged commit db8b6b0 into microsoft:master Sep 5, 2017
@StrikerRUS StrikerRUS deleted the python2 branch September 5, 2017 13:59
guolinke pushed a commit that referenced this pull request Oct 9, 2017
* fixed sklearn test on python 2.7

* commit to show that problem has been solved

* come back to python 3.6

* removed warnings check
@lock lock bot locked as resolved and limited conversation to collaborators Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants