Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][App Compat] REAPER, Studio One, and Bitwig Studio crash when receiving certain messages using WinMM #517

Open
Psychlist1972 opened this issue Feb 5, 2025 · 4 comments
Assignees
Labels
area-transports 🚌 General transports like USB, BLE, Network, etc. area-windows-internal 🪟 Related to internal (not in the repo) Windows bug 🐞 Something isn't working fixed-awaiting-public-release 🕙 Fixed in our internal builds. Waiting to make its way to a public release.

Comments

@Psychlist1972
Copy link
Contributor

Release Customer Preview 1, Canary 27788

App crashes after key-up on notes recorded from Montage M. Testing additional instruments and apps, but wanted to get this documented in case others run into it.

Image

@Psychlist1972 Psychlist1972 added area-transports 🚌 General transports like USB, BLE, Network, etc. area-windows-internal 🪟 Related to internal (not in the repo) Windows bug 🐞 Something isn't working labels Feb 5, 2025
@Psychlist1972 Psychlist1972 self-assigned this Feb 5, 2025
@Psychlist1972 Psychlist1972 changed the title [BUG][WinMM App Compat] REAPER and Bitwig Studio crash when recording notes from Montage M [BUG][WinMM App Compat] REAPER, Studio One, and Bitwig Studio crash when recording notes from Montage M using WinMM Feb 5, 2025
@Psychlist1972 Psychlist1972 changed the title [BUG][WinMM App Compat] REAPER, Studio One, and Bitwig Studio crash when recording notes from Montage M using WinMM [BUG] REAPER, Studio One, and Bitwig Studio crash when recording notes from Montage M (MIDI 2.0 device using UMP) using WinMM Feb 6, 2025
@Psychlist1972
Copy link
Contributor Author

Testing so far:

MIDI 1.0 device using old class driver: works
MIDI 1.0 device using new class driver: works
MIDI 2.0 device using new class driver: crashes the apps.

This is likely something related to translation. Maybe our in-box build did not pick up the correct version of libmidi2. Too early to tell.

@Psychlist1972 Psychlist1972 changed the title [BUG] REAPER, Studio One, and Bitwig Studio crash when recording notes from Montage M (MIDI 2.0 device using UMP) using WinMM [BUG][WinMM App Compat] REAPER, Studio One, and Bitwig Studio crash when recording notes from Montage M (MIDI 2.0 device using UMP) using WinMM Feb 6, 2025
@Psychlist1972
Copy link
Contributor Author

I believe we have this discovered. It wasn't related to MIDI 2.0, but to the montage sending lots of active sensing messages. We had some incorrect single-byte-message handling in wdmaud2.drv.

Validating that now.

@Psychlist1972
Copy link
Contributor Author

Quick update on this: we had some incorrect logic in handling incoming messages for WinMM/MME client applications. We're getting this fixed and will have those fixes in a future Canary release.

@Psychlist1972 Psychlist1972 changed the title [BUG][WinMM App Compat] REAPER, Studio One, and Bitwig Studio crash when recording notes from Montage M (MIDI 2.0 device using UMP) using WinMM [BUG][WinMM App Compat] REAPER, Studio One, and Bitwig Studio crash when receiving certain messages using WinMM Feb 8, 2025
@Psychlist1972
Copy link
Contributor Author

There was message corruption based on handling in the WinMM shim of certain notes under 3 bytes in length, under some conditions. Unfortunately, those conditions were very common (active sensing, clock, etc.). There will be a fix in the code base, soon, but unsure yet when that will move to Canary. I'll update here as I have more info.

@Psychlist1972 Psychlist1972 added the fixed-awaiting-public-release 🕙 Fixed in our internal builds. Waiting to make its way to a public release. label Feb 9, 2025
@Psychlist1972 Psychlist1972 changed the title [BUG][WinMM App Compat] REAPER, Studio One, and Bitwig Studio crash when receiving certain messages using WinMM [BUG][App Compat] REAPER, Studio One, and Bitwig Studio crash when receiving certain messages using WinMM Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-transports 🚌 General transports like USB, BLE, Network, etc. area-windows-internal 🪟 Related to internal (not in the repo) Windows bug 🐞 Something isn't working fixed-awaiting-public-release 🕙 Fixed in our internal builds. Waiting to make its way to a public release.
Projects
Status: No status
Development

No branches or pull requests

1 participant