add comment and rename variable to $ReturnValue

microsoft · Sep 17, 2020 · 29b0537 · 29b0537
1 parent e12f7db
commit 29b0537
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/MIDebugEngine/Engine.Impl/DebuggedProcess.cs b/src/MIDebugEngine/Engine.Impl/DebuggedProcess.cs
@@ -1237,6 +1237,7 @@ private async Task HandleBreakModeEvent(ResultEventArgs results, BreakRequest br
                 }
             }
             // step over/into
+            // NB: unfortunately this event does not provide a return value: https://sourceware.org/bugzilla/show_bug.cgi?id=26354
             else if (reason == "end-stepping-range")
                 _callback.OnStepComplete(thread);
             // step out
@@ -1245,7 +1246,7 @@ private async Task HandleBreakModeEvent(ResultEventArgs results, BreakRequest br
                 string resultVar = results.Results.TryFindString("gdb-result-var"); // a gdb value history var like "$1"
                 if (!string.IsNullOrEmpty(resultVar))
                 {
-                    ReturnValue = new VariableInformation("Function return value", resultVar, cxt, Engine, (AD7Thread)thread.Client, isParameter: false);
+                    ReturnValue = new VariableInformation("$ReturnValue", resultVar, cxt, Engine, (AD7Thread)thread.Client, isParameter: false);
                     await ReturnValue.Eval();
                 }
                 _callback.OnStepComplete(thread);