Support ClipboardContext for Evaluate Request #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users who want to copy the full string from the UI will use "copy value" from the EE windows. This will send an EvaluateRequest with the context of Clipboard. This PR noticies the context in OpenDebugAD7 and uses IDebugExpressionDAP with DAPEvalFlag ClipboardContext set for MIEngine to query. If it is set, MIEngine will save the previous value of 'show print elements', set it to unlimited, and reset it back to the original value after it evaluates the variable. Then it will provide the full string back to the user to copy.
|
Otherwise LGTM. |
pieandcakes
reviewed
Jun 11, 2020
pieandcakes
reviewed
Jun 11, 2020
pieandcakes
reviewed
Jun 11, 2020
pieandcakes
requested changes
Jun 11, 2020
src/Microsoft.VisualStudio.Debugger.Interop.DAP/Microsoft.VisualStudio.Debugger.Interop.DAP.cs
Show resolved
Hide resolved
gregg-miskelly
approved these changes
Jun 12, 2020
pieandcakes
reviewed
Jun 12, 2020
pieandcakes
reviewed
Jun 12, 2020
src/Microsoft.VisualStudio.Debugger.Interop.DAP/Microsoft.VisualStudio.Debugger.Interop.DAP.cs
Outdated
Show resolved
Hide resolved
pieandcakes
approved these changes
Jun 12, 2020
src/Microsoft.VisualStudio.Debugger.Interop.DAP/Microsoft.VisualStudio.Debugger.Interop.DAP.cs
Outdated
Show resolved
Hide resolved
pieandcakes
reviewed
Jun 12, 2020
pieandcakes
reviewed
Jun 12, 2020
| IDebugProperty2 property; | ||
| hr = expressionObject.EvaluateSync(flags, Constants.EvaluationTimeout, null, out property); | ||
| if (expressionObject is IDebugExpressionDAP expressionDapObject) |
There was a problem hiding this comment.
Can you just check the context value in this if block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Requires VS Code 1.46.0 to work. Previous engines set the expression to be the value of the original expression instead of the actual expression.