Fixing Conditional Breakpoints for VS Code #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS Code has modified the way it handles conditional breakpoints. It used to send a SetBreakpoints that removed the breakpoint and a new SetBreakpoints request with the updated condition. First we validate existing breakpoint's conditions have not changed, if they have, we delete and recreate it internally.
WardenGnaw
force-pushed
the
dev/waan/fixConditionalBP
branch
from
1741bfa
to
11d0815
Compare
pieandcakes
reviewed
Jun 12, 2020
pieandcakes
reviewed
Jun 12, 2020
pieandcakes
approved these changes
Jun 12, 2020
|
Do you need to do the same for function breakpoints? |
Is there a way to set function breakpoints with conditions in VS Code? |
Fixed some error messages Fixed pr issues
Oh, I guess you are right. I didn't notice. Though it is possible to do in VS and we now use this code in VS, so maybe worth fixing anyway? |
gregg-miskelly
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS Code has modified the way it handles conditional breakpoints.
It used to send a SetBreakpoints that removed the breakpoint and a new
SetBreakpoints request with the updated condition.
This change now keeps track of breakpoint conditions and recreate them
if the condition has changed.